Clear base image entrypoint #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the ENTRYPOINT from the base image.
This was a vestige of the pre-beta design where we were using ENTRYPOINT rather than CMD. Currently, the image generated by App Engine Flex during deployment must clear the ENTRYPOINT and set CMD instead. We'd like to clean this up so that images based on this base image don't have to clear the ENTRYPOINT. We also want to match other language base images, which all either use CMD or don't set a default at all.
This is a potential breaking change if any users have a custom image based on the ruby base image that depend on the default ENTRYPOINT setting. I don't expect this would happen commonly if ever, since the Dockerfile generated by
app gen-config --customclears the ENTRYPOINT itself. (It would not affectruntime: rubycustomers at all.) I talked with @JustinBeckwith about this and I think I convinced him it should be okay while we're still in beta. @thagomizer @remi @hxiong388 any objections?