Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: retry database cleanup task #1300

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Conversation

NivedhaSenthil
Copy link
Member

  • Database cleanup task fails sporadically due to Deadline Exceeded error which happen due to various reasons including network issues they are safe to retry.
  • This PR adds an exponential retry for the task.

Description

Fixes #1191

Note: It's a good idea to open an issue first for discussion.

Checklist

  • Tests pass
  • Lint pass: bundle exec rubocop
  • Please merge this PR for me once it is approved.

- Database cleanup task fails sporadically due to Deadline Exceeded error which happen due to various reasons including network issues they are safe to retry.
- This PR adds an exponential retry for the task.
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Feb 23, 2024
@NivedhaSenthil NivedhaSenthil marked this pull request as ready for review February 26, 2024 09:35
@NivedhaSenthil NivedhaSenthil requested a review from a team as a code owner February 26, 2024 09:35
Copy link
Contributor

@SandeepTuniki SandeepTuniki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NivedhaSenthil NivedhaSenthil merged commit 68c6cf4 into main Feb 27, 2024
7 checks passed
@SandeepTuniki SandeepTuniki deleted the retry_cleanup_database branch February 27, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rspec: Spanner database JSON datatype add_json_column_update_and_query_data failed
2 participants