Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Fix broken tests with CircleCI #211

Merged
merged 39 commits into from
Dec 11, 2017
Merged

[Tests] Fix broken tests with CircleCI #211

merged 39 commits into from
Dec 11, 2017

Conversation

frankyn
Copy link
Member

@frankyn frankyn commented Nov 7, 2017

No description provided.

@frankyn
Copy link
Member Author

frankyn commented Dec 11, 2017

Remaining failures are flakes. I'll add a retry to existing tests using rspec-retry gem which extends Ruby RSpec to have retry capabilities.

@frankyn
Copy link
Member Author

frankyn commented Dec 11, 2017

Merging after adding retries to Storage, Pubsub, Logging, and Datastore. I didn't want to overwhelm the test code with adding retries to all sample tests yet. Tests are green, will reopen issue if they break after merge.

@frankyn frankyn merged commit 2d7bb43 into master Dec 11, 2017
@frankyn frankyn deleted the fix-broken-tests branch December 11, 2017 22:40
@frankyn frankyn changed the title [Tests] [WIP] Fix broken tests with CircleCI [Tests] Fix broken tests with CircleCI Dec 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant