Add firebase auth support to endpoints sample. #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #32 |
|
logging and language are failing, appengine/endpoints passes: |
|
Awesome! Taking a look... |
beccasaurus
reviewed
Oct 27, 2016
|
|
||
| before do | ||
| content_type :json | ||
| end | ||
|
|
||
| use Rack::Cors do |
There was a problem hiding this comment.
Nice find with Rack::Cors 👍
There was a problem hiding this comment.
Aja pointed me to: https://til.hashrocket.com/posts/4d7f12b213-rails-5-api-and-cors
beccasaurus
suggested changes
Oct 27, 2016
| get "/auth/info/firebase" do | ||
| auth_info | ||
| end | ||
| options "/auth/info/firebase" do |
There was a problem hiding this comment.
nit: can you add a newline above options "..." do so the handlers are separated by 1 newline?
jeffmendoza
force-pushed
the
jlm/endpoints-firebase-auth
branch
from
4dd850c
to
054a436
Compare
|
Updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't find any example clients or docs for testing firebase auth in the Python or Go examples, so going with this until we have more docs on https://cloud.google.com/endpoints/docs/authenticating-users