Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore): Process SQLServer CDC tables and UI bug fixes #640

Merged
merged 6 commits into from
Oct 3, 2023
Merged

(chore): Process SQLServer CDC tables and UI bug fixes #640

merged 6 commits into from
Oct 3, 2023

Conversation

manitgupta
Copy link
Member

  1. Addresses: b/300771260 - SQLServer CDC enabled tables were not processed due to being excluded in the SQL query used to query INFORMATION_SCHEMA. Updated the query and tested schema migration and POC schema-and-data migration for SQLServer for both CDC enabled and disabled tables.
  2. Fixed a bug where Minimal downtime migration would appear in the dropdown for SQLServer.
  3. MigrationType has no significance when a customer is doing a schema migration. Removed the migrationType dropdown when a customer selects schema migration.

@manitgupta manitgupta marked this pull request as ready for review September 25, 2023 05:29
bharadwaj-aditya
bharadwaj-aditya approved these changes Sep 28, 2023
View reviewed changes
Copy link
Collaborator

@bharadwaj-aditya bharadwaj-aditya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@manitgupta manitgupta merged commit d5e7e96 into GoogleCloudPlatform:master Oct 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharadwaj-aditya bharadwaj-aditya bharadwaj-aditya approved these changes

@shreyakhajanchi shreyakhajanchi Awaiting requested review from shreyakhajanchi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@manitgupta @bharadwaj-aditya