-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing migrationProjectId and decoupling Spanner projectId #802
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #802 +/- ##
==========================================
- Coverage 45.96% 45.92% -0.04%
==========================================
Files 166 166
Lines 20013 20032 +19
Branches 471 471
==========================================
+ Hits 9199 9200 +1
- Misses 10300 10318 +18
Partials 514 514
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Added some comments to check if there is an opportunity to simplify by using context
instead of adding a new parameter wherever possible.
This is not a small amount to work to figure out quickly! Thanks a lot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes, looks much bigger than what I originally thought!
f87d11e
to
8868056
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR description with -
- What is to be done as follow up work. Create bugs and linked them here.
- What testing has been done. I would recommend smoke testing the common pathways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please also update the Github documentation with these changes
- Please update the PR description with what features break under what scenarios. For example -
cleanup
CLI will not work for cases when spanner project is different from migration resources project (and so on and so forth)
f9e1dde
to
8474f13
Compare
Updated the description with manual testing done and listed down the pending tasks. |
I have updated the github documentation as well |
Introduced migration project id. Utilized the new migration project id to create migration resources instead of spanner's project id.
Tested:
Pending tasks:
Feature request - UI support for separate migration shard id #807
Feature request - Correct cleanup command to store and use migration project id from metadata db #808
Feature request - Document permissions required to run migration with different migration project and spanner project #809
Documentation - Document usage of Cleanup command in the github documentation page #810
Tests pass
Appropriate changes to README are included in PR