-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference Documentation issues #2101
Comments
Memo. This is the document https://googlecloudplatform.github.io/spring-cloud-gcp/reference/html/index.html. This is linked from this section in README.md: |
Pasting some investigation notes on the failing 4.x refdoc job:
Suspicious logs:
Key differences are in lines 24 and 32. v3.x uses Java 11 and These differences are minimal and shouldn't be the cause of failure, but just noting here for reference. Something odd is happening with the 4.x workflow where it is copying all versions instead of just the specified one. Will dig into that some more. |
Have narrowed down the issue that the 4.x workflow where when it's running the Further evidence that it's this function is that the script succeeds when run locally using the Relevant failing log lines:
Passing log lines:
|
The issue appears to be within this function within
where it is not building the Have tentatively narrowed down the issue to the two plugins within the
It appears that in a successful run, those two plugins are downloaded from Maven central as part of building the docs and thus generate documentation within the In a failed run, these two plugins are not downloaded. Still digging into why. |
@alicejli Check whether "./mvnw clean install -P docs -pl docs -DskipTests -X" succeeded or not. |
Yes, this is the part that only partially succeeds in the failed runs. It says it builds successfully, but it does not build the (sorry I meant to reply but I think I updated your original comment by accident). |
Not making too much progress figuring out what's causing the build discrepancy, so going to pivot to looking at how other Spring projects are generating their reference docs and seeing how/if we can use their workflow. For reference to dig into later: https://github.com/spring-projects/spring-framework/blob/main/.github/workflows/deploy-docs.yml |
As part of #2101, update reference documentation links in README to reflect current. Deleted 2.0.11 ref doc links as it's already out of support. Added tag to allow auto update for the latest 4.x version ref doc and javadoc. However, for 3.x versions, manual update is still needed.
As part of #2101, update reference documentation links in README to reflect current. Deleted 2.0.11 ref doc links as it's already out of support. Added tag to allow auto update for the latest 4.x version ref doc and javadoc. However, for 3.x versions, manual update is still needed.
All issues are resolved. |
The text was updated successfully, but these errors were encountered: