Customize thread name prefixes for subscription specific TaskSchedulers

[poznachowski]

Currently thread names for subscription specific Task Schedulers are lengthy as they comprise of
gcp-pubsub-subscriber- + fully qualified subscription name, ex:
gcp-pubsub-subscriber-projects/fake project/subscriptions/subscription-name1

This may result in a lengthy log statement, if thread name is a part of it.

This MR allows customization of subscription specific Task Scheduler's thread names.

[elefeint]

It's a nice improvement, but unfortunately accepting a bean in GcpPubSubAutoConfiguration constructor that is defined in the same autoconfiguration class leads to a circular reference. You can test this by starting up the sample app.

I see two ways around this:

1. creating defaultSelectiveSchedulerThreadNameProvider in a new autoconfiguration class,
2. not providing a default bean at all and instead accepting Optional<SelectiveSchedulerThreadNameProvider> selectiveSchedulerThreadNameProvider in the constructor. Then in registerSelectiveSchedulerBeans, the default would end up hardcoded as before:

        String threadName = selectiveSchedulerThreadNameProvider.isPresent() ? 
            selectiveSchedulerThreadNameProvider.get().getThreadName(fullSubscriptionName) : 
            "gcp-pubsub-subscriber-" + qualifiedName;

The second way seems simpler to me, but it's your call.

Also, could you turn on google style and reformat? mvn validate will run style checks to make sure it's good.

[poznachowski]

You're obviously right, sorry for that.
I went the latter route, but used Spring's ObjectProvider as I find it more consistent with other autoconfiguration classes I've seen. Even GcpPubSubAutoconfiguration uses ObjectProvider a lot.
mvn validate runs successfully now.

[elefeint]

Looks great!
Would you mind adding a line or two to the Subscription-specific Configurations section in the reference documentation?

[poznachowski]

Sure, reference added. Please check if that concludes the change.

[elefeint]

Thank you very much!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[poznachowski]

Hey @elefeint ! I don't know where to ask this question elsewhere - Do you have any ETA for publishing new version of spring-cloud-gcp ?

[elefeint]

We'll release in the next 2 weeks. Need to get Spring Boot 2.7 compatibility in.