Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SpannerStatementQueryExecutor query generation for IsNotNull conditions #1171

Merged
merged 2 commits into from
Jun 17, 2022

Conversation

zhumin8
Copy link
Contributor

@zhumin8 zhumin8 commented Jun 17, 2022

fixes #1168.

When including IsNotNull conditions in query methods by convention, Spanner query fails with error Query failed: Operands of <> cannot be literal NULL with property<>NULL syntax. Changing to property IS NOT NULL instead.

@sonarcloud
Copy link

sonarcloud bot commented Jun 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@zhumin8 zhumin8 requested a review from elefeint June 17, 2022 18:08
@zhumin8 zhumin8 merged commit 07cb451 into main Jun 17, 2022
@zhumin8 zhumin8 deleted the fix-spanner-isnotnull branch June 17, 2022 20:33
kateryna216 added a commit to kateryna216/spring-cloud-gcp that referenced this pull request Oct 20, 2022
…ditions (GoogleCloudPlatform#1171)

* use is not null instead of <>null.

* add integration test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spanner repo method generates invalid query for IsNotNull conditions
2 participants