Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CreateDisposition configurable on BigQueryTemplate #1286

Merged

Conversation

seakayone
Copy link
Contributor

@seakayone seakayone commented Oct 11, 2022

This change is adding the possibility to be able to change the CreateDisposition (CREATE_IF_NEEDED or CREATE_NEVER) on the BigQueryTemplate ackin to how you would currently configure the WriteDisposition.

In our use case we have to use CREATE_NEVER because we want to prevent even the attempt to create a table in BigQuery. Currently this is only be possible by using a BigQuery instance directly, because the CreateDisposition is not passed through by the template to the WriteChannelConfiguration and eventually the writer falls back to the CREATE_IF_NEEDED default.

@google-cla
Copy link

google-cla bot commented Oct 11, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@seakayone seakayone force-pushed the feature/add-create-disposition branch from 9b640a7 to a45a63a Compare October 11, 2022 07:30
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@elefeint elefeint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@prash-mi FYI -- eventually, perhaps both WriteDisposition and CreateDisposition could become properties.

@elefeint elefeint merged commit 1c5a42b into GoogleCloudPlatform:main Oct 14, 2022
kateryna216 added a commit to kateryna216/spring-cloud-gcp that referenced this pull request Oct 20, 2022
…latform#1286)

Co-authored-by: Christian Kleinbölting <seakayone@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants