Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Spring Boot 3.2 compatibility #2321

Closed
wants to merge 4 commits into from

Conversation

burkedavison
Copy link
Member

  • Verify isReadable=true is correct for SpannerCompositeKeyProperty
  • Discuss change in generic types of PubSubSubscriptionHealthIndicatorAutoConfiguration with @meltsufin
  • Add Java 21 check

* deps: spring cloud 2023.0.0-M2 and spring boot 3.2.0-RC1

* fix: SpannerCompositeKeyProperty implements isReadable

* fix: PubSubHealthIndicatorAutoConfiguration uses indicator factory injection

* fix: SpannerHealthIndicatorAutoConfiguration uses indicator factory injection

* chore: add PubSubSubscriptionHealthIndicatorAutoConfigurationTests

* fix: PubSubSubscriptionHealthIndicatorAutoConfiguration explicitly does not support indicator creation

* fix: Remove @OverRide from SpannerCompositeKeyProperty.isReadable

* fix: PubSubSubscriptionHealthIndicatorAutoConfiguration generics changed

* chore: Test PubSubSubscriptionHealthIndicatorAutoConfiguration

* fix: imports

* fix: GqlDatastoreQuery isPaged logic
@burkedavison
Copy link
Member Author

burkedavison commented Nov 1, 2023

Prior to updating samples' pom.xml parent to use org.springframework.boot:spring-boot-starter-parent:3.2.0-RC1:

Caused by: 
  org.springframework.beans.factory.BeanCreationException: 
    Error creating bean with name 'compositeCompatibilityVerifier' defined in class path resource [org/springframework/cloud/configuration/CompatibilityVerifierAutoConfiguration.class]: 
      Failed to instantiate [org.springframework.cloud.configuration.CompositeCompatibilityVerifier]: 
        Factory method 'compositeCompatibilityVerifier' threw exception with message: 
          Spring Cloud/ Spring Boot version compatibility checks have failed: 
            [[VerificationResult@4182a651 
              description = 'Spring Boot [3.1.5] is not compatible with this Spring Cloud release train', 
              action = 'Change Spring Boot version to one of the following versions [3.2.x] .

You can find the latest Spring Boot versions here [https://spring.io/projects/spring-boot#learn]. 
If you want to learn more about the Spring Cloud Release train compatibility, you can visit this page [https://spring.io/projects/spring-cloud#overview] and check the [Release Trains] section.
If you want to disable this check, just set the property [spring.cloud.compatibility-verifier.enabled=false]']]

See Spring Cloud's Release Train compatibility table

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant