Allow placeholders in Cloud SQL config #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Secret Manager placehoders are still skipped as before. Fixes: #491.
elefeint
approved these changes
Jun 8, 2021
| // Bind properties without resolving placeholders | ||
| Binder binder = new Binder(ConfigurationPropertySources.get(environment), null, null, null, null); | ||
| // Bind properties without resolving Secret Manager placeholders | ||
| Binder binder = new Binder(ConfigurationPropertySources.get(environment), new PlaceholdersResolver() { |
There was a problem hiding this comment.
Want to refactor this into a nested class? It's not so trivial, plus there are additional parameters after the anonymous class...
dzou
approved these changes
Jun 8, 2021
|
Kudos, SonarCloud Quality Gate passed! |
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
Secret Manager placehoders are still skipped as before. Fixes: GoogleCloudPlatform#491.
prash-mi
pushed a commit
that referenced
this pull request
Jun 20, 2023
This PR adds three additional types of parameter binding:
1) primitive arrays. These were straightforward to match, knowing the incoming object type, and are implemented with existing `ClientLibraryTypeBinderImpl`.
2) wrapper type arrays or primitive arrays where type conversion is needed. These need to be converted from an array to a list to use the list-accepting overloads of client library value binder. I've implemented a helper class `ArrayToIterableBinder` to avoid duplicating list creation boilerplate.
3) Iterable/Collection. This was harder, since the client library has typed binding methods, but parameterized types aren't real ("reified") in Java. This is, however, possible with R2DBC SPI 0.9 `Parameter.in()` binding. It's implemented with one binder for all `Iterable` needs -- `IterableBinder`, which uses some hardcoded type maps in `SpannerType`. I've updated `ClientLibraryTypeBinder` to accept `SpannerType` hints, but for now only the `IterableBinder` uses these values. We may have use for the additional type hinting in the future, though, so we might as well give the binders all useful information up front.
(3) is not necessary to bind collections with Spring Data, because all collections get converted to arrays internally, so by the time the value gets to the driver, it's already an easily digestible array. `SpannerArrayColumns` and `SpannerR2dbcDialect` changes are needed to trigger this logic in Spring Data.
I've simplified the front-end to send and retrieve a whole Book object, because adding another field with another button would be too complicated for users.
Fixes #481.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secret Manager placehoders are still skipped as before.
Fixes: #491.