Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update additional-spring-configuration-metadata to contain missing ma… #543

Merged
merged 3 commits into from
Jul 21, 2021

Conversation

Alos
Copy link
Contributor

@Alos Alos commented Jul 21, 2021

This change adds the missing management endpoint found in the documentation to the additional-spring-configuration-metadata.json. This will allow IDEs to provide proper tooltips and recognize the property.

Fixes: #542

…nagement.health.pubsub configuration

This change adds the missing management endpoint found in the [documentation](https://googlecloudplatform.github.io/spring-cloud-gcp/2.0.3/reference/html/index.html#cloud-pubsub-health-indicator) to the metadata. This will allow IntelliJ to provide proper tooltips and recognize the property by users. 

Fix: GoogleCloudPlatform#542
Alos and others added 2 commits July 21, 2021 12:29
…itional-spring-configuration-metadata.json

Co-authored-by: Mike Eltsufin <meltsufin@google.com>
…itional-spring-configuration-metadata.json

Co-authored-by: Mike Eltsufin <meltsufin@google.com>
@sonarcloud
Copy link

sonarcloud bot commented Jul 21, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Alos Alos requested a review from meltsufin July 21, 2021 19:42
@meltsufin meltsufin merged commit 235707a into GoogleCloudPlatform:main Jul 21, 2021
kateryna216 added a commit to kateryna216/spring-cloud-gcp that referenced this pull request Oct 20, 2022
GoogleCloudPlatform#543)

* Update additional-spring-configuration-metadata to contain missing management.health.pubsub configuration

This change adds the missing management endpoint found in the [documentation](https://googlecloudplatform.github.io/spring-cloud-gcp/2.0.3/reference/html/index.html#cloud-pubsub-health-indicator) to the metadata. This will allow IntelliJ to provide proper tooltips and recognize the property by users. 

Fixes: GoogleCloudPlatform#524.

Co-authored-by: Mike Eltsufin <meltsufin@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

management.health.pubsub.enabled missing in additional-spring-configuration-metadata.json
2 participants