Remove spring-cloud-build dependency; add spring-boot BOM explicitly #804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
meltsufin
requested changes
Dec 16, 2021
| @@ -64,6 +64,7 @@ | |||
| <skipTests>false</skipTests> | |||
| <spring-cloud-build.version>3.0.4</spring-cloud-build.version> | |||
There was a problem hiding this comment.
No, we are still using it for the checkstyle plugin. This will go away soon -- I am thinking the best time to do the checkstyle changes is right before forking off Spring Cloud GCP 2.x (with Spring Boot 2.5 support) and leaving the main branch to be Spring Cloud GCP 3.x (with Spring Boot 2.6 support).
meltsufin
approved these changes
Dec 16, 2021
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
…oogleCloudPlatform#804) Remove spring-cloud-build dependency; add spring-boot BOM explicitly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently derive Spring Boot versions indirectly, through Spring Cloud Build. That's not ideal because for Spring Cloud Build, it's a minor infrastructural detail, while users of Spring Cloud GCP can get the version of Spring Boot through our starters.
We should explicitly maintain the version of Spring Boot.
Fixes #801.