Close Spanner health check ResultSet to prevent session leak #902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meltsufin
requested changes
Jan 25, 2022
...c/main/java/com/google/cloud/spring/autoconfigure/spanner/health/SpannerHealthIndicator.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed! |
ddixit14
approved these changes
Jan 25, 2022
meltsufin
approved these changes
Jan 25, 2022
elefeint
added a commit
that referenced
this pull request
Jan 28, 2022
* close result set to prevent session leak * restrict visibility of test methods * use try-with-resources to close the resultset
elefeint
added a commit
that referenced
this pull request
Jan 28, 2022
kateryna216
added a commit
to kateryna216/spring-cloud-gcp
that referenced
this pull request
Oct 20, 2022
…loudPlatform#902) * close result set to prevent session leak * restrict visibility of test methods * use try-with-resources to close the resultset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verified that the session pool stays stable after the fix using one of the Spanner samples, plus actuator dependency.
Fixes #891.