Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Single resource modules can be removed #18

Open
bharathkkb opened this issue Mar 15, 2023 · 1 comment
Open

Single resource modules can be removed #18

bharathkkb opened this issue Mar 15, 2023 · 1 comment
Assignees
@donmccasland
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. triaged Scoped and ready for work type: cleanup An internal cleanup or hygiene concern.

Comments

@bharathkkb
Copy link
Member

Single resource internal modules do not offer any advantage over just having this in the root module

https://github.com/GoogleCloudPlatform/terraform-example-deploy-java-multizone/blob/main/infra/modules/filestore/main.tf
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label May 14, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale May 22, 2023
@bharathkkb bharathkkb added triaged Scoped and ready for work and removed Stale labels May 23, 2023
@bharathkkb bharathkkb reopened this May 23, 2023
@kweinmeister kweinmeister added type: cleanup An internal cleanup or hygiene concern. priority: p2 Moderately-important priority. Fix may not be included in next release. labels May 24, 2023
@donmccasland donmccasland self-assigned this Jul 14, 2023
@donmccasland donmccasland added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donmccasland donmccasland

Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. triaged Scoped and ready for work type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@donmccasland @bharathkkb @kweinmeister