Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding Secure Web Proxy to examples #36

Closed
wants to merge 31 commits into from
Closed

feat: Adding Secure Web Proxy to examples #36

wants to merge 31 commits into from

Conversation

Samir-Cit
Copy link
Collaborator

@Samir-Cit Samir-Cit commented May 25, 2023

Hey folks.

This PR adds the Secure Web Proxy (SWP/SWG) to the BigQuery and CloudSQL example.

@Samir-Cit Samir-Cit requested review from a team, prabhu34 and gtsorbo as code owners May 25, 2023 18:33
@Samir-Cit Samir-Cit marked this pull request as draft May 25, 2023 18:34
@Samir-Cit
Copy link
Collaborator Author

Still need to update the source for secure_web_proxy module.

This update will be done as soon as the module is merged:
#34

@amandakarina
Copy link
Collaborator

/gcbrun

@amandakarina
Copy link
Collaborator

/gcbrun

@amandakarina
Copy link
Collaborator

/gcbrun

@amandakarina
Copy link
Collaborator

/gcbrun

@amandakarina
Copy link
Collaborator

/gcbrun

@amandakarina
Copy link
Collaborator

/gcbrun

@amandakarina
Copy link
Collaborator

/gcbrun

@amandakarina
Copy link
Collaborator

/gcbrun

@amandakarina
Copy link
Collaborator

/gcbrun

@amandakarina
Copy link
Collaborator

/gcbrun

@Samir-Cit Samir-Cit changed the title feat: Adding Secure Web Proxy to BigQuery example feat: Adding Secure Web Proxy to BigQuery and CloudSQL example May 30, 2023
@Samir-Cit Samir-Cit changed the title feat: Adding Secure Web Proxy to BigQuery and CloudSQL example feat: Adding Secure Web Proxy to examples Jun 1, 2023
* Grants Cloud Functions Invoker to EventArc Trigger Service Account.
* Enables Container Registry Automatic Scanning.

* The Example will create besides all secure-cloud-function resources:
Copy link
Collaborator

@daniel-cit daniel-cit Jun 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The Example will create besides all secure-cloud-function resources:
* In addition to all the secure-cloud-function resources created, this example will also create:

@Samir-Cit
Copy link
Collaborator Author

Changes moved to the following PR: #44

@Samir-Cit Samir-Cit closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants