Add cloud identity group #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add cloud identity to mm * make labels key value pair * add cloud identity group * fix white spacing, add description to update test * make tests beta-only * make customer id var beta-only * Update products/cloudidentity/api.yaml Co-authored-by: Dana Hoffman <danahoffman@google.com> * Update products/cloudidentity/terraform.yaml Co-authored-by: Dana Hoffman <danahoffman@google.com> * update code review comments * move unless ga to top of file for test * move unless ga back * add group membership back in * remove last comma * update per review comments * add group membership test for user * update admin -> identity, tabs -> spaces Co-authored-by: Dana Hoffman <danahoffman@google.com> Signed-off-by: Modular Magician <magic-modules@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hashicorp/terraform-provider-google#3479
I've commented out a few un-implemented things (per email thread), but will update/include them as I hear back from the rest of the team.
Release Note Template for Downstream PRs (will be copied)
Derived from GoogleCloudPlatform/magic-modules#3696