Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Conversation

modular-magician
Copy link
Collaborator

fixes hashicorp/terraform-provider-google#10100 : "google_vertex_ai_featurestore_entitytype: Cannot determine region: set in this resource, or set provider-level 'region' or 'zone' #10100.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

vertex_ai:  made google_vertex_ai_featurestore_entitytype always use regional endpoint corresponding to parent's region

Derived from GoogleCloudPlatform/magic-modules#6588

…pe (#6588)

* fix: added parameter region to google_vertex_ai_featurestore_entitytype

* Revert "fix: added parameter region to google_vertex_ai_featurestore_entitytype"

This reverts commit ddf67919b021469c9f3e4593426bfedd127cd6fb.

* fix: extract region from the featurestore id

* fix: add custom_import for the region field

* fix: 2nd attempt to fix the custom_import override

* fix: 3rd attempt to fix the custom_import for the region field

* fix: 4th attempt to fix the custom_import for the region field

* fix: reverted the custom_import back

* fix: use the right import code for the custom_import

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner November 7, 2022 18:35
@modular-magician modular-magician requested review from iyabchen and removed request for a team November 7, 2022 18:35
@modular-magician modular-magician merged commit 82babd0 into GoogleCloudPlatform:main Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant