Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Conversation

modular-magician
Copy link
Collaborator

Added handling of amd64 images on the compute disk.
fixes hashicorp/terraform-provider-google#12907

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: fixed perma-diff on `google_compute_disk` for new amd64 images

Derived from GoogleCloudPlatform/magic-modules#6769

* Added handling of amd64 images on compute disk

* Removed Test Cases from the TestDiskImageDiffSuppress

* Added test cases for amd64 images

Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner November 7, 2022 20:02
@modular-magician modular-magician requested review from iyabchen and removed request for a team November 7, 2022 20:02
@modular-magician modular-magician merged commit 785c20c into GoogleCloudPlatform:main Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test(s): TestAccComputeDisk_imageDiffSuppressPublicVendorsFamilyNames
1 participant