Skip to content
This repository has been archived by the owner on May 15, 2023. It is now read-only.

Support BigQuery authorized routines #1098

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Support BigQuery authorized routines #1098

merged 1 commit into from
Nov 8, 2022

Conversation

modular-magician
Copy link
Collaborator

Add support for authorized routines on BigQuery.

Fixes hashicorp/terraform-provider-google#11501 .

I just tested to assign some routines as an authorized routines to some datasets using local built provider.
But I can not run acceptance tests.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

bigquery: supported authorized routines on resource `bigquery_dataset` and `bigquery_dataset_access`

Derived from GoogleCloudPlatform/magic-modules#6680

@modular-magician @melinath
Support BigQuery authorized routines (#6680)
38b7b38 
* BigQuery: Added support for authorized routine

* BigQuery: Added examples for authorized routine

* Update mmv1/products/bigquery/terraform.yaml

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* Update mmv1/templates/terraform/examples/bigquery_dataset_authorized_routine.tf.erb

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

* add legacy iam access to test case

* remove legacy roles

* correct variable names and values

* replace - to _

* [wip]added hand written test

* fix corrupted test

* Update mmv1/third_party/terraform/tests/resource_bigquery_dataset_access_test.go

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>

Co-authored-by: Stephen Lewis (Burrows) <stephen.r.burrows@gmail.com>
Signed-off-by: Modular Magician <magic-modules@google.com>
@modular-magician modular-magician requested a review from a team as a code owner November 8, 2022 17:51
@modular-magician modular-magician requested review from iyabchen and removed request for a team November 8, 2022 17:51
@modular-magician modular-magician merged commit 6af534b into GoogleCloudPlatform:main Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iyabchen iyabchen Awaiting requested review from iyabchen iyabchen is a code owner automatically assigned from GoogleCloudPlatform/terraform-validator-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support BigQuery authorized routines
1 participant
@modular-magician