-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to support xDS Federation #33
Conversation
@ejona86 : I have reviewed this PR and looks fine to me. Do you mind taking a quick look as well? Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look fine, but this doesn't actually fix #32 entirely, correct, because we want the c2p stuff to be present?
Yes, this change only addresses basic federation. The c2p changes would follow after this. |
Yes I can add c2p changes as a separate task in #32 |
as per a47 xDS Federation spec we need to add the authorities field.
For the authorities field, we want two entries:
For both these entries, we will leave the value empty or {}. That way, they will still both end up talking to TD with the server config specified by the top-level
Note that in
authorities
map authority name's value is empty. This is to force default to thexds_server_uri
specified in the top levelxds_servers
field.Fixes task 1 in #32