Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MDS url for getClusterLocality #54

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

arvindbr8
Copy link
Member

@arvindbr8 arvindbr8 commented Jan 26, 2024

While testing the generator prior to releasing the new --gke-cluster-location-experimental, I found that there was a typo in the MDS API endpoint used by getClusterLocality.

I've tested the new changes in a Kubernetes container, please see below

Testing details

Project name: arvindbright-k8n-test

Cluster name: arvindbright-test-ssa

Pod name: psm-grpc-client-8568fccdc6-44qht

root@psm-grpc-client-8568fccdc6-44qht:/traffic-director-grpc-bootstrap# ./td-grpc-bootstrap --generate-mesh-id-experimental
{
  "xds_servers": [
    {
      "server_uri": "trafficdirector.googleapis.com:443",
      "channel_creds": [
        {
          "type": "google_default"
        }
      ],
      "server_features": [
        "xds_v3"
      ]
    }
  ],
  "authorities": {
    "traffic-director-c2p.xds.googleapis.com": {
      "xds_servers": [
        {
          "server_uri": "dns:///directpath-pa.googleapis.com",
          "channel_creds": [
            {
              "type": "google_default"
            }
          ],
          "server_features": [
            "xds_v3",
            "ignore_resource_deletion"
          ]
        }
      ],
      "client_listener_resource_name_template": "xdstp://traffic-director-c2p.xds.googleapis.com/envoy.config.listener.v3.Listener/%s"
    }
  },
  "node": {
    "id": "projects/439293274322/networks/mesh:gsmmesh-b0qq-arvindbright-test-ssa-us-west1-c-b0qq2zt1szea/nodes/8b268b69-7771-4199-afd9-585c5b44563d",
    "cluster": "cluster",
    "metadata": {
      "INSTANCE_IP": "10.124.0.12",
      "TRAFFICDIRECTOR_GRPC_BOOTSTRAP_GENERATOR_SHA": "f967c161f666855e6cc52fbec08c90c0188cb8a3"
    },
    "locality": {
      "zone": "us-west1-c"
    }
  },
  "certificate_providers": {
    "google_cloud_private_spiffe": {
      "plugin_name": "file_watcher",
      "config": {
        "certificate_file": "/var/run/secrets/workload-spiffe-credentials/certificates.pem",
        "private_key_file": "/var/run/secrets/workload-spiffe-credentials/private_key.pem",
        "ca_certificate_file": "/var/run/secrets/workload-spiffe-credentials/ca_certificates.pem",
        "refresh_interval": "600s"
      }
    }
  },
  "server_listener_resource_name_template": "grpc/server?xds.resource.listening_address=%s"
}

@arvindbr8 arvindbr8 added the bug Something isn't working label Jan 26, 2024
arvindbr8 added a commit to arvindbr8/traffic-director-grpc-bootstrap that referenced this pull request Jan 26, 2024
@arvindbr8 arvindbr8 merged commit 644bf6b into GoogleCloudPlatform:master Jan 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants