Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloudbuild: Publish preprod image to Artifact Registry #58

Merged

Conversation

sergiitk
Copy link
Member

@sergiitk sergiitk commented Apr 8, 2024

Migrates TD gRPC bootstrap from Container Registry (gcr.io) to Artifact Registry (pkg.dev). Container Registry deprecation notice: https://cloud.google.com/container-registry/docs/deprecations/container-registry-deprecation.

All preprod images are from gcr.io/grpc-testing/td-grpc-bootstrap to us-docker.pkg.dev/grpc-testing/trafficdirector/td-grpc-bootstrap.

This updates cloudbuild config to publish all new preprod images to Artifact Registry.

Migrates TD gRPC bootstrap from Container Registry (gcr.io) to
Artifact Registry (pkg.dev). Container Registry deprecation notice:
https://cloud.google.com/container-registry/docs/deprecations/container-registry-deprecation.

All preprod images are from gcr.io/grpc-testing/td-grpc-bootstrap to
us-docker.pkg.dev/grpc-testing/trafficdirector/td-grpc-bootstrap.

This updates cloudbuild config to publish all new preprod images to
Artifact Registry.
@arvindbr8
Copy link
Member

cc: @ejona86

@arvindbr8 arvindbr8 merged commit 5446fce into GoogleCloudPlatform:master Apr 9, 2024
2 checks passed
@sergiitk sergiitk deleted the move-preprod-image-to-pkg-dev branch April 9, 2024 17:31
sergiitk added a commit to grpc/psm-interop that referenced this pull request Apr 9, 2024
Migrates PSM Interop and TD gRPC bootstrap preprod images from Container
Registry (gcr.io) to Artifact Registry (pkg.dev). Container Registry
deprecation notice:
https://cloud.google.com/container-registry/docs/deprecations/container-registry-deprecation.

Related:
- Ref b/289578176
- Bootstrap Generator:
GoogleCloudPlatform/traffic-director-grpc-bootstrap#58
- Java: grpc/grpc-java#11079
- Go: grpc/grpc-go#7102
- CPP: grpc/grpc#36273
- Node: grpc/grpc-node#2712
Copy link
Collaborator

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants