Fixing session id to be something per user as oppose to global hard-c… #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpp/client.cc
Outdated
| context.AddMetadata("membership", "premium"); | ||
| if (affinity) { | ||
| // use something unique per user as session id. | ||
| context.AddMetadata("session_id", token); |
There was a problem hiding this comment.
Are we supposed to use the same value for session_id and authorization token?
There was a problem hiding this comment.
I just picked token as it is already per user; but we can invent something else per user (so we are not confusing people in this example). Maybe that's better?
There was a problem hiding this comment.
Yeah, I think that would be better. cc @menghanl who just added go support.
There was a problem hiding this comment.
Yeah, let's use a different value.
There was a problem hiding this comment.
ok sounds good! Fixed! PTAL thank you!
menghanl
approved these changes
Sep 13, 2021
This was referenced Sep 16, 2021
dapengzhang0
added a commit
that referenced
this pull request
Oct 13, 2021
dapengzhang0
added a commit
to dapengzhang0/traffic-director-grpc-examples
that referenced
this pull request
Oct 13, 2021
This is the Java version of GoogleCloudPlatform#82 to fix the session affinity id. Fixes GoogleCloudPlatform#83
2 tasks
dapengzhang0
added a commit
that referenced
this pull request
Oct 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…oded.