Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add authentication #88

Merged
merged 2 commits into from
Oct 5, 2021
Merged

fix: add authentication #88

merged 2 commits into from
Oct 5, 2021

Conversation

nicain
Copy link
Contributor

@nicain nicain commented Oct 4, 2021

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@nicain nicain force-pushed the issue/71 branch 4 times, most recently from 4a0b48e to bb7edc7 Compare October 4, 2021 23:56
@nicain nicain force-pushed the issue/71 branch 2 times, most recently from f0ef9b5 to 0728fa3 Compare October 5, 2021 21:20
@nicain
Copy link
Contributor Author

nicain commented Oct 5, 2021

Reported weird flake8 issue to nbQA-dev/nbQA#665. This probably won't be an issue for anyone else, unless they have parlai installed in the sample environment as the one that is used for testing

@nicain nicain marked this pull request as ready for review October 5, 2021 21:50
@nicain nicain requested a review from ivanmkc as a code owner October 5, 2021 21:50
ivanmkc
ivanmkc approved these changes Oct 5, 2021
View reviewed changes
Copy link
Contributor

@ivanmkc ivanmkc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nicain nicain added the automerge Summon MOG for automerging label Oct 5, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 421a96d into master Oct 5, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Summon MOG for automerging label Oct 5, 2021
@nicain nicain mentioned this pull request Oct 6, 2021
Closed
@MarcoGorelli
Copy link

Reported weird flake8 issue to nbQA-dev/nbQA#665. This probably won't be an issue for anyone else, unless they have parlai installed in the sample environment as the one that is used for testing

parlai installs a flake8 extension, so this is working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanmkc ivanmkc ivanmkc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicain @MarcoGorelli @ivanmkc