-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Lstat() Instead of Stat() #247
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@midnightconman thanks for the contribution! tests would be great :) could you add a unit test? it would also be great to show an example using this, if you think that's possible.
@midnightconman any update here? I'd be happy to merge this with a test. |
@midnightconman Hi, do you need help with test? I'd be more than happy to help. @nkubala How can I help? should I open a new PR with missing test? |
@charlyx thanks for jumping in. if @midnightconman can give you write access to their branch, you could simply update this PR and we could merge it, but i'm not sure that will happen in a timely manner. if you'd like to open a PR with a test and reference it in this one, we can just merge both. |
This PR switches the tar driver from using
os.Stat()
toos.Lstat()
... this enables symlink file existence testing with the tar driver.If tests are needed, please let me know... I verified functionality manually (via testing existence of symlinks in a docker image).