Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Lstat() Instead of Stat() #247

Closed

Conversation

midnightconman
Copy link

This PR switches the tar driver from using os.Stat() to os.Lstat()... this enables symlink file existence testing with the tar driver.

If tests are needed, please let me know... I verified functionality manually (via testing existence of symlinks in a docker image).

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@midnightconman
Copy link
Author

midnightconman commented Mar 10, 2020

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@midnightconman thanks for the contribution! tests would be great :) could you add a unit test? it would also be great to show an example using this, if you think that's possible.

@nkubala
Copy link
Contributor

nkubala commented Jul 1, 2020

@midnightconman any update here? I'd be happy to merge this with a test.

@charlyx
Copy link
Contributor

charlyx commented Oct 28, 2020

@midnightconman Hi, do you need help with test? I'd be more than happy to help.

@nkubala How can I help? should I open a new PR with missing test?

@nkubala
Copy link
Contributor

nkubala commented Nov 4, 2020

@charlyx thanks for jumping in. if @midnightconman can give you write access to their branch, you could simply update this PR and we could merge it, but i'm not sure that will happen in a timely manner.

if you'd like to open a PR with a test and reference it in this one, we can just merge both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants