Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for unbound env variables #282

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

czunker
Copy link
Contributor

@czunker czunker commented Aug 30, 2021

This will check the metadata whether the specified env variables really aren't present.

Fixes #281

Signed-off-by: Christian Zunker christian.zunker@codecentric.cloud

This will check the metadata whether the specified env variables really aren't present.

Fixes GoogleContainerTools#281

Signed-off-by: Christian Zunker <christian.zunker@codecentric.cloud>
@czunker czunker requested a review from nkubala as a code owner August 30, 2021 07:38
@google-cla
Copy link

google-cla bot commented Aug 30, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@czunker
Copy link
Contributor Author

czunker commented Aug 30, 2021

@googlebot I signed it!

Copy link
Contributor

@nkubala nkubala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@czunker thank you for the contribution! this change looks good, but I'd like to see tests added for all new additions to the code :)

would you mind adding some tests to the tests/{ARCH}/*_metadata_test.yaml files, e.g. https://github.com/GoogleContainerTools/container-structure-test/blob/master/tests/amd64/ubuntu_20_04_metadata_test.yaml? you should just be able to add small tests using this new field and they should be run as normal in the integration tests.

@czunker
Copy link
Contributor Author

czunker commented Nov 11, 2021

@nkubala Thanks for the feedback.
I'll have a look at the tests and add them to this PR.

@czunker
Copy link
Contributor Author

czunker commented Nov 11, 2021

Hi @nkubala ,

tests are present and running tests/structure_test_tests.sh worked out fine.
Please have a look.

@nkubala nkubala merged commit f7305b3 into GoogleContainerTools:master Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add metadata check for absence of env varibale
2 participants