-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for unbound env variables #282
Add test for unbound env variables #282
Conversation
This will check the metadata whether the specified env variables really aren't present. Fixes GoogleContainerTools#281 Signed-off-by: Christian Zunker <christian.zunker@codecentric.cloud>
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@czunker thank you for the contribution! this change looks good, but I'd like to see tests added for all new additions to the code :)
would you mind adding some tests to the tests/{ARCH}/*_metadata_test.yaml
files, e.g. https://github.com/GoogleContainerTools/container-structure-test/blob/master/tests/amd64/ubuntu_20_04_metadata_test.yaml? you should just be able to add small tests using this new field and they should be run as normal in the integration tests.
@nkubala Thanks for the feedback. |
Hi @nkubala , tests are present and running |
This will check the metadata whether the specified env variables really aren't present.
Fixes #281
Signed-off-by: Christian Zunker christian.zunker@codecentric.cloud