-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix JUnit report format #310
fix JUnit report format #310
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I'm not actually sure what this integration test is waiting for. If you want to trigger this with some sort of rebase or other minor change, maybe we can merge it in. |
* edited this line for readability * trying not to make this suck :)
7d558c6
to
2fd3f4e
Compare
Looks like it's waiting on a manual approval. @loosebazooka would you mind kicking it off? |
Yeah I dunno what's going on. But I approved it now |
Fixes #273 & #304
I added two new types to handle the JUnit specific marshaling. This probably can be implemented a bit better rather than inline structs + new types just for making encoding/xml happy.
tests pass. Had to make a tweak to tests/structure_test_tests.sh get the script to run correctly. Could use a pair of eyes to make sure its kosher 👀