Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert io_bazel_rules_go to v0.35.0 #1384

Merged

Conversation

dahu33
Copy link
Contributor

@dahu33 dahu33 commented Aug 23, 2023

Fixes #1381

rules_go is broken for the ppc64le arch since version v0.36.0 which introduced this change.

Until bazelbuild/rules_go#3531 is resolved a good workaround is to revert to v0.35.0.

@google-cla
Copy link

google-cla bot commented Aug 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@loosebazooka
Copy link
Member

I realize I should've done this, but since you're in here can you add a comment in the build file so we know why we're still at 0.35.0?

@dahu33
Copy link
Contributor Author

dahu33 commented Aug 24, 2023

I realize I should've done this, but since you're in here can you add a comment in the build file so we know why we're still at 0.35.0?

Done, thanks!

@loosebazooka loosebazooka merged commit 4d4fe63 into GoogleContainerTools:main Aug 24, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't build out of the box
2 participants