-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build powerpc (ppc64le) distroless base and static images #622
Merged
chanseokoh
merged 2 commits into
GoogleContainerTools:master
from
dims:add-support-for-ppc64le
Oct 20, 2020
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,77 @@ | ||
| { | ||
| "base-files": "10.3+deb10u6", | ||
| "ca-certificates": "20200601~deb10u1", | ||
| "curl": "7.64.0-4+deb10u1", | ||
| "dash": "0.5.10.2-5", | ||
| "fontconfig-config": "2.13.1-2", | ||
| "fonts-dejavu-core": "2.37-1", | ||
| "libacl1": "2.2.53-4", | ||
| "libattr1": "1:2.4.48-4", | ||
| "libbz2-1.0": "1.0.6-9.2~deb10u1", | ||
| "libc-bin": "2.28-10", | ||
| "libc6": "2.28-10", | ||
| "libcomerr2": "1.44.5-1+deb10u3", | ||
| "libcurl4": "7.64.0-4+deb10u1", | ||
| "libdb5.3": "5.3.28+dfsg1-0.5", | ||
| "libexpat1": "2.2.6-2+deb10u1", | ||
| "libffi6": "3.2.1-9", | ||
| "libfontconfig1": "2.13.1-2", | ||
| "libfreetype6": "2.9.1-3+deb10u1", | ||
| "libgcc1": "1:8.3.0-6", | ||
| "libgcrypt20": "1.8.4-5", | ||
| "libgmp10": "2:6.1.2+dfsg-4", | ||
| "libgnutls30": "3.6.7-4+deb10u5", | ||
| "libgomp1": "8.3.0-6", | ||
| "libgpg-error0": "1.35-1", | ||
| "libgssapi-krb5-2": "1.17-3", | ||
| "libhogweed4": "3.4.1-1", | ||
| "libicu63": "63.1-6+deb10u1", | ||
| "libidn11": "1.33-2.2", | ||
| "libidn2-0": "2.0.5-1+deb10u1", | ||
| "libjpeg62-turbo": "1:1.5.2-2+b1", | ||
| "libk5crypto3": "1.17-3", | ||
| "libkeyutils1": "1.6-6", | ||
| "libkrb5-3": "1.17-3", | ||
| "libkrb5support0": "1.17-3", | ||
| "liblcms2-2": "2.9-3", | ||
| "libldap-2.4-2": "2.4.47+dfsg-3+deb10u2", | ||
| "libldap-common": "2.4.47+dfsg-3+deb10u2", | ||
| "liblttng-ust0": "2.10.3-1", | ||
| "liblzma5": "5.2.4-1", | ||
| "libmpdec2": "2.4.2-2", | ||
| "libncursesw6": "6.1+20181013-2+deb10u2", | ||
| "libnettle6": "3.4.1-1", | ||
| "libnghttp2-14": "1.36.0-2+deb10u1", | ||
| "libp11-kit0": "0.23.15-2", | ||
| "libpcre3": "2:8.39-12", | ||
| "libpng16-16": "1.6.36-6", | ||
| "libpsl5": "0.20.2-2", | ||
| "libpython2.7-minimal": "2.7.16-2+deb10u1", | ||
| "libpython2.7-stdlib": "2.7.16-2+deb10u1", | ||
| "libpython3.7-minimal": "3.7.3-2+deb10u2", | ||
| "libpython3.7-stdlib": "3.7.3-2+deb10u2", | ||
| "libreadline7": "7.0-5", | ||
| "librtmp1": "2.4+20151223.gitfa8646d.1-2", | ||
| "libsasl2-2": "2.1.27+dfsg-1+deb10u1", | ||
| "libsasl2-modules-db": "2.1.27+dfsg-1+deb10u1", | ||
| "libselinux1": "2.8-1+b1", | ||
| "libsqlite3-0": "3.27.2-3", | ||
| "libssh2-1": "1.8.0-2.1", | ||
| "libssl1.1": "1.1.1d-0+deb10u3", | ||
| "libstdc++6": "8.3.0-6", | ||
| "libtasn1-6": "4.13-3", | ||
| "libtinfo6": "6.1+20181013-2+deb10u2", | ||
| "libunistring2": "0.9.10-1", | ||
| "libuuid1": "2.33.1-0.1", | ||
| "mime-support": "3.62", | ||
| "netbase": "5.6", | ||
| "openjdk-11-jdk-headless": "11.0.8+10-1~deb10u1", | ||
| "openjdk-11-jre-headless": "11.0.8+10-1~deb10u1", | ||
| "openssl": "1.1.1d-0+deb10u3", | ||
| "python2.7-minimal": "2.7.16-2+deb10u1", | ||
| "python3-distutils": "3.7.3-1", | ||
| "python3.7-minimal": "3.7.3-2+deb10u2", | ||
| "readline-common": "7.0-5", | ||
| "tzdata": "2020a-0+deb10u1", | ||
| "zlib1g": "1:1.2.11.dfsg-1" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| { | ||
| "base-files": "9.9+deb9u13", | ||
| "ca-certificates": "20200601~deb9u1", | ||
| "curl": "7.52.1-5+deb9u10", | ||
| "dash": "0.5.8-2.4", | ||
| "fontconfig-config": "2.11.0-6.7", | ||
| "fonts-dejavu-core": "2.37-1", | ||
| "libacl1": "2.2.52-3+b1", | ||
| "libattr1": "1:2.4.47-2+b2", | ||
| "libbz2-1.0": "1.0.6-8.1", | ||
| "libc-bin": "2.24-11+deb9u4", | ||
| "libc6": "2.24-11+deb9u4", | ||
| "libcomerr2": "1.44.5-1~bpo9+1", | ||
| "libcurl3": "7.52.1-5+deb9u10", | ||
| "libdb5.3": "5.3.28-12+deb9u1", | ||
| "libexpat1": "2.2.0-2+deb9u3", | ||
| "libffi6": "3.2.1-6", | ||
| "libfontconfig1": "2.11.0-6.7+b1", | ||
| "libfreetype6": "2.6.3-3.2+deb9u1", | ||
| "libgcc1": "1:6.3.0-18+deb9u1", | ||
| "libgcrypt20": "1.7.6-2+deb9u3", | ||
| "libgmp10": "2:6.1.2+dfsg-1", | ||
| "libgnutls30": "3.5.8-5+deb9u5", | ||
| "libgomp1": "6.3.0-18+deb9u1", | ||
| "libgpg-error0": "1.35-1~bpo9+1", | ||
| "libgssapi-krb5-2": "1.15-1+deb9u1", | ||
| "libhogweed4": "3.3-1+b2", | ||
| "libicu57": "57.1-6+deb9u4", | ||
| "libidn11": "1.33-1+deb9u1", | ||
| "libidn2-0": "2.0.5-1~bpo9+1", | ||
| "libjpeg62-turbo": "1:1.5.1-2", | ||
| "libk5crypto3": "1.15-1+deb9u1", | ||
| "libkeyutils1": "1.5.9-9", | ||
| "libkrb5-3": "1.15-1+deb9u1", | ||
| "libkrb5support0": "1.15-1+deb9u1", | ||
| "liblcms2-2": "2.8-4+deb9u1", | ||
| "libldap-2.4-2": "2.4.47+dfsg-3+deb10u2~bpo9+1", | ||
| "libldap-common": "2.4.47+dfsg-3+deb10u2~bpo9+1", | ||
| "liblttng-ust0": "2.9.0-2+deb9u1", | ||
| "liblzma5": "5.2.2-1.2+b1", | ||
| "libmpdec2": "2.4.2-1", | ||
| "libncursesw5": "6.0+20161126-1+deb9u2", | ||
| "libnettle6": "3.3-1+b2", | ||
| "libnghttp2-14": "1.18.1-1+deb9u1", | ||
| "libp11-kit0": "0.23.3-2", | ||
| "libpcre3": "2:8.39-3", | ||
| "libpng16-16": "1.6.28-1+deb9u1", | ||
| "libpsl5": "0.17.0-3", | ||
| "libpython2.7-minimal": "2.7.13-2+deb9u3", | ||
| "libpython2.7-stdlib": "2.7.13-2+deb9u3", | ||
| "libpython3.5-minimal": "3.5.3-1+deb9u1", | ||
| "libpython3.5-stdlib": "3.5.3-1+deb9u1", | ||
| "libreadline7": "7.0-3", | ||
| "librtmp1": "2.4+20151223.gitfa8646d.1-1+b1", | ||
| "libsasl2-2": "2.1.27~101-g0780600+dfsg-3+deb9u1", | ||
| "libsasl2-modules-db": "2.1.27~101-g0780600+dfsg-3+deb9u1", | ||
| "libselinux1": "2.6-3+b3", | ||
| "libsqlite3-0": "3.27.2-3~bpo9+1", | ||
| "libssh2-1": "1.7.0-1+deb9u1", | ||
| "libssl1.0.2": "1.0.2u-1~deb9u1", | ||
| "libssl1.1": "1.1.0l-1~deb9u1", | ||
| "libstdc++6": "6.3.0-18+deb9u1", | ||
| "libtasn1-6": "4.10-1.1+deb9u1", | ||
| "libtinfo5": "6.0+20161126-1+deb9u2", | ||
| "libunistring0": "0.9.6+really0.9.3-0.1", | ||
| "libuuid1": "2.29.2-1+deb9u1", | ||
| "mime-support": "3.60", | ||
| "netbase": "5.4", | ||
| "openjdk-11-jdk-headless": "11.0.6+10-1~bpo9+1", | ||
| "openjdk-11-jre-headless": "11.0.6+10-1~bpo9+1", | ||
| "openjdk-8-jdk-headless": "8u252-b09-1~deb9u1", | ||
| "openjdk-8-jre-headless": "8u252-b09-1~deb9u1", | ||
| "openssl": "1.1.0l-1~deb9u1", | ||
| "python2.7-minimal": "2.7.13-2+deb9u3", | ||
| "python3.5-minimal": "3.5.3-1+deb9u1", | ||
| "readline-common": "7.0-3", | ||
| "tzdata": "2020a-0+deb9u1", | ||
| "zlib1g": "1:1.2.8.dfsg-5" | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't this be in
BASE_ARCHITECTURES?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chanseokoh i was just following the pattern set by the s390x :) we can revisit this in a subsequent PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that like
s390xthis is a starting point to get base & static in place?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the only reason that we distinguish
BASE_ARCHITECTURESandARCHITECTURESis to include or excludelibunwind8because Debian doesn't have the library package on s390x.So, the consequence of this would be that, Distroless won't be able to build ppc64le dotnet images (dotnet requires
libunwind8, as it seems).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that this is a major issue. We just need to be clear on why we have both
BASE_ARCHITECTURESandARCHITECTURESfor what reason.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but
s390xdoesn't publish python, node, or other images yet, so practically I think the "base" signifies what we publish//basefor, but this may be back-filling the naming a bit 😅There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but I do think
ppc64le(basically any arch that doesn't need special handling such as x390x) should be inBASE_ARCHITECTURES. I can tolerate a brief transition state if this is to be fixed in a subsequent PR.