Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add google creds to both containers and initContainers #24

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

akakakakakaa
Copy link
Contributor

Hi, I want to use google credentials to initcontainer also.

I think there is common use case that run a container after downloading metadata from initcontainer.

@google-cla
Copy link

google-cla bot commented May 27, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@sharifelgamal
Copy link
Contributor

Hey @akakakakakaa, this seems like a reasonable change. If you sign the CLA, I can test and merge it.

@akakakakakaa
Copy link
Contributor Author

akakakakakaa commented Jun 9, 2022

Thank you for your response @sharifelgamal . I changed commit to CLA verified email.

@sharifelgamal sharifelgamal merged commit b85ef96 into GoogleContainerTools:main Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants