Skip to content

Commit

Permalink
Fix release by ignoring SNAPSHOT deps on core/plugins-common (#1987)
Browse files Browse the repository at this point in the history
the SNAPSHOT dependencies are a consequence of the monolith, the
release plugin just needs to ingore those projects, ideally the
plugin wouldn't care that compileOnly dependencies are SNAPSHOTS
but whatever, they might have a reason for that.
  • Loading branch information
loosebazooka committed Sep 13, 2019
1 parent 92ee431 commit 5b39a34
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
1 change: 1 addition & 0 deletions jib-gradle-plugin/build.gradle
Expand Up @@ -33,6 +33,7 @@ dependencies {
// Prepare release
release {
tagTemplate = 'v$version-gradle'
ignoredSnapshotDependencies = ["com.google.cloud.tools:jib-core", "com.google.cloud.tools:jib-plugins-common"]
git {
requireBranch = /^gradle_release_v\d+.*$/ //regex
}
Expand Down
3 changes: 2 additions & 1 deletion jib-maven-plugin/build.gradle
Expand Up @@ -56,7 +56,8 @@ publishing {


release {
tagTemplate = 'v$version-gradle'
tagTemplate = 'v$version-maven'
ignoredSnapshotDependencies = ["com.google.cloud.tools:jib-core", "com.google.cloud.tools:jib-plugins-common"]
git {
requireBranch = /^maven_release_v\d+.*$/ //regex
}
Expand Down

0 comments on commit 5b39a34

Please sign in to comment.