Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for OCI images. #108

Merged
merged 11 commits into from
Feb 22, 2018
Merged

Adds support for OCI images. #108

merged 11 commits into from
Feb 22, 2018

Conversation

coollog
Copy link
Contributor

@coollog coollog commented Feb 20, 2018

Part of #96

  • Adds OCIManifestTemplate to be like V22ManifestTemplate, except with OCI-specific media types.
  • Adds BuildableManifestTemplate to encompass both OCIManifestTemplate and V22ManifestTemplate.

Still need to:

  • Add configuration to build/push as OCI format.

@coollog coollog added this to the 0.1.3 milestone Feb 20, 2018
@coollog coollog changed the title Adds support for OCI images. Build and push OCI images. Feb 20, 2018
@coollog coollog changed the title Build and push OCI images. Adds support for build and push as OCI image. Feb 20, 2018
@coollog coollog changed the title Adds support for build and push as OCI image. Adds support for OCI images. Feb 20, 2018
@coollog coollog mentioned this pull request Feb 20, 2018
2 tasks
@loosebazooka
Copy link
Member

The structure is a little weird to me, feels like if they are the exact same template, then it should just be one file, and if there are different (OCI has more params?) then it should be two separate classes? If V22 is just a subset of OCI, then it should be able to be handled by the OCI class?

Would this kind of structure work here?

interface BuildableManifest {
  getSchemaVersion
  getMediaType
  getConfig
  getLayers
}

refactor out the common classes -- layers, config

class V22Manfiest {
  schemaversion
  mediatype
  config
  layers
}

class OCIManfiest {
  schemaversion
  mediatype
  config
  layers
  ... anything else?
}

@coollog
Copy link
Contributor Author

coollog commented Feb 22, 2018

Changed BuildableManifestTemplate to an interface (which involved changing JsonTemplate to an interface as well)

@coollog coollog merged commit ac2b814 into master Feb 22, 2018
@coollog coollog deleted the oci branch February 22, 2018 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants