Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor cleanups #2196

Merged
merged 3 commits into from Dec 11, 2019
Merged

Minor cleanups #2196

merged 3 commits into from Dec 11, 2019

Conversation

chanseokoh
Copy link
Member

No description provided.

@TadCordle
Copy link
Contributor

TadCordle commented Dec 11, 2019

What's with the travis failure?

/home/travis/build/GoogleContainerTools/jib/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/GradleProjectProperties.java:238: error: cannot find symbol
          consoleLogger.log(Level.DEBUG, "Using JAR: " + jarPath);
                            ^

@chanseokoh
Copy link
Member Author

That's a complete non-sense. The /pr Travis build is for running builds after merging this PR, so perhaps something got confused or mixed up. I've rebased at HEAD, so let's see if this works.

@chanseokoh
Copy link
Member Author

Aha, kind of merge conflicts, since consoleLogger.log() was introduced in a separate PR. Taken care of after merged with master.

@TadCordle
Copy link
Contributor

Hmm, travis still failing, but because it's failing to unzip something.

@chanseokoh
Copy link
Member Author

Suspected Travis cache corruption. Cleared the cache, reran Travis, and it seems working.

@chanseokoh chanseokoh merged commit 2f05348 into master Dec 11, 2019
@chanseokoh chanseokoh deleted the chanseok-cleanups-minor branch December 11, 2019 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants