Inherit USER from base image #2426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wonder if some discussion led us to do this? Would this break existing builds that depend on ignoring user? <-- although maybe this is a dumb question |
|
Hmm... good point. I don't remember such a thing though. Let me search. |
|
In #595, we had been gradually expanding configurations to inherit. Inheriting I do think there will be users whose images we will break with this change. |
|
Sure then this should be a 2.3.0? |
|
Just curious though, can a user override the inherited user? |
loosebazooka
approved these changes
Apr 23, 2020
|
Yes, with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2421.
I think we never inherited USER.