Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extraDirectories filtering to match relative path #3181

Merged
merged 1 commit into from Apr 2, 2021

Conversation

chanseokoh
Copy link
Member

@chanseokoh chanseokoh commented Apr 1, 2021

Most of the time, you'll specify a relative path in <includes> and <excludes>, which is the case in all of our tests.

Turns out we need to relativize local path to match against the glob matchers. The reason the tests seemed to work was that we always started with **/, which works for absolute path. That is, previously, includes = ['foo'] didn't work.


Previous PR: #3173
Issues: #2564 #3164

@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #3181 (0098c29) into master (6a415b8) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #3181   +/-   ##
=========================================
  Coverage     71.18%   71.19%           
  Complexity     2331     2331           
=========================================
  Files           279      279           
  Lines          9846     9848    +2     
  Branches        990      990           
=========================================
+ Hits           7009     7011    +2     
  Misses         2491     2491           
  Partials        346      346           
Impacted Files Coverage Δ Complexity Δ
...jib/plugins/common/JavaContainerBuilderHelper.java 95.45% <100.00%> (+0.14%) 21.00 <3.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a415b8...0098c29. Read the comment docs.

Copy link
Contributor

@mpeddada1 mpeddada1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chanseokoh chanseokoh merged commit 053a1d7 into master Apr 2, 2021
@chanseokoh chanseokoh deleted the fix-extra-dirs-filtering branch April 2, 2021 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants