Checkout a specific git commit

[why-xn]

Description

I have added support for checking out to a specific git commit. For this, the git url pattern should be like below.

git://[repository url][#reference][#commit-id]

Reviewer Notes

• The code flow looks good.
• Unit tests and or integration tests added.

Release Notes

• Support for checking out a specific git commit

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[why-xn]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[tejal29]

Can you please add more explanation around whyr.Head() is necessary?
It would be great to add some tests around this integration.
Please see your existing Git Context integration test.

[tejal29]

@why-xn Thank you for your contribution!
In order to make sure, this integration is not broken, please add

1. either unit tests or
2. Integration tests

Can you also explain how feature will benefit the community?
Is the idea to build on some older commit in the git workspace?

[tomprince]

I would find something like this useful in a CI pipeline, where the kaniko task might end being run after another commit was pushed. In that case, it should be possible to run kaniko in such a way that the image built comes from the commit the rest of the pipeline is expecting, rather than whatever commit happend to get pushed later.

[tejal29]

I would find something like this useful in a CI pipeline, where the kaniko task might end being run after another commit was pushed. In that case, it should be possible to run kaniko in such a way that the image built comes from the commit the rest of the pipeline is expecting, rather than whatever commit happend to get pushed later.

Thanks for the explanation @tomprince. Not aware how other pipeline orchestrator works. I am most familiar with tekton and it supports running a pipeline at a git commit which other tasks in pipeline (in this case kaniko will run on)
Your use case also sounds legit. Just curios do you have your own pipeline orchestrator ?

[tomprince]

Thanks for the explanation @tomprince. Not aware how other pipeline orchestrator works. I am most familiar with tekton and it supports running a pipeline at a git commit which other tasks in pipeline (in this case kaniko will run on)
Your use case also sounds legit. Just curios do you have your own pipeline orchestrator ?

I will note that I probably won't use this, since we have additional constraints that means we need to wrap kaniko, but might use something like this without those contraints.

I'm not sure of @why-xn setup, but I know the setup we use does not support persistent volumes between different tasks in a pipeline, so would want to pin the commit here.

[aca]

Hope this get merged. I build very simple [git push -> webhook -> build] pipeline in my company.
I experience same problem like tomprince mentioned.

In that case, it should be possible to run kaniko in such a way that the image built comes from the commit the rest of the pipeline is expecting, rather than whatever commit happend to get pushed later.

[aca]

@why-xn Seems like review is requested. Any updates on this?

[tejal29]

@why-xn Can you add some unit tests?

[gcalmettes]

Confirming that this would be a very nice and useful feature to have. Thanks for considering this !