feat: support multiple registry mirrors with fallback #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GoogleContainerTools#1473 The initial implementation of the registry mirror only allowed a single mirror, and if pulling from the mirror failed, the build would fail. This change introduces: - multiple registry mirrors instead of a single one - fallback if an image can't be pulled from a registry This is the same behavior as the docker daemon and will allow using a registry mirror such as `mirror.gcr.io` which is incomplete and doesn't have all the content that the default registry on docker.io has. Note that there are no changes in the CLI flags, the `--registry-mirror` flag is still valid. But now it can be used multiple times to set up more than one registry mirror.
vbehar
force-pushed
the
multiple-mirrors
branch
from
9731733
to
6220dbd
Compare
4 tasks
|
@tejal29 hi, do you think you might have time to review this PR? or maybe someone else? thanks a lot! |
tejal29
approved these changes
Dec 9, 2020
|
Thanks @vbehar. Unfortunately i am the only active maintainer. Would love to onboard new maintainers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1473
Description
The initial implementation of the registry mirror only allowed a single mirror, and if pulling from the mirror failed, the build would fail.
This change introduces:
This is the same behavior as the docker daemon and will allow using a registry mirror such as
mirror.gcr.iowhich is incomplete and doesn't have all the content that the default registry on docker.io has.Note that there are no changes in the CLI flags, the
--registry-mirrorflag is still valid. But now it can be used multiple times to set up more than one registry mirror.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.