Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flag to disable pushing cache #2038

Merged
merged 1 commit into from May 16, 2022
Merged

feat: add flag to disable pushing cache #2038

merged 1 commit into from May 16, 2022

Conversation

jasondamour
Copy link
Contributor

Fixes #2036

Description

  1. If --no-push and --no-push-cache are both true, then check only pull permissions, not pull+push
  2. If --no-push-cache is true, then skip pushing cache layers

Submitter Checklist

  • Includes unit tests
  • Adds integration tests if needed.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

- kaniko adds a new flag `--no-push-cache` to independently control the pushing of the cache. If both --no-push and --no-push-cache are set, then kaniko only needs read permissions on the registry.

@jasondamour jasondamour mentioned this pull request Apr 9, 2022
Closed
tejal29
tejal29 approved these changes May 16, 2022
View reviewed changes
Copy link
Member

@tejal29 tejal29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tejal29 tejal29 merged commit 872758b into GoogleContainerTools:main May 16, 2022
@gabyx
Copy link
Contributor

gabyx commented May 17, 2022 •
edited

This breaks, main CI please only merge stuff when tests pass... ?

@gabyx
Copy link
Contributor

gabyx commented May 17, 2022

@tejal29: please merge #2094
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tejal29 tejal29 tejal29 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jasondamour @gabyx @tejal29