Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Clarify README.md blurb on --cache-copy-layers #2064

Merged
merged 1 commit into from May 16, 2022

Conversation

korenyoni
Copy link
Contributor

@korenyoni korenyoni commented Apr 27, 2022

Relates to #1940

Description

This clarifies the blurb on --cache-copy-layers in README.md, which is misleading to readers and can imply that it controls layer caching for both RUN and COPY, but in fact only refers to COPY as the name of the flag suggests.

Related issues:

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

@google-cla
Copy link

google-cla bot commented Apr 27, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@tejal29 tejal29 merged commit ce1fb51 into GoogleContainerTools:main May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants