Reproducing and Fixing #2892

[mxbossard]

Reproducing and Fixing #2892

Description
Firstly : attempt to reproduce in integration tests.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes unit tests
• Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

• The code flow looks good.
• Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

[mxbossard]

I think I reproduced the bug with a now failing integration test. But I don't understand why the unit tests are failing. Can you help me ?

[JeromeJu]

I think I reproduced the bug with a now failing integration test. But I don't understand why the unit tests are failing. Can you help me ?

FAILED /home/runner/work/kaniko/kaniko/scripts/../hack/gofmt.sh
RUN /home/runner/work/kaniko/kaniko/scripts/../hack/linter.sh
Installing GolangCI-Lint
golangci/golangci-lint info checking GitHub for tag 'v1.51.1'
golangci/golangci-lint info found version: 1.51.1 for v1.51.1/linux/amd64
golangci/golangci-lint info installed /home/runner/work/kaniko/kaniko/hack/bin/golangci-lint
level=warning msg="[runner] The linter 'golint' is deprecated (since v1.41.0) due to: The repository of the linter has been archived by the owner.  Replaced by revive."
level=warning msg="[runner] The linter 'interfacer' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner. "
level=warning msg="[runner] The linter 'maligned' is deprecated (since v1.38.0) due to: The repository of the linter has been archived by the owner.  Replaced by govet 'fieldalignment'."
level=warning msg="[linters_context] rowserrcheck is disabled because of generics. You can track the evolution of the generics support by following the https://github.com/golangci/golangci-lint/issues/2649."
integration/integration_test.go:650: File is not `goimports`-ed (goimports)
		"-v", cwd + ":/cache",
FAILED /home/runner/work/kaniko/kaniko/scripts/../hack/linter.sh
make: *** [Makefile:67: test] Error 1
Error: Process completed with exit code 2.

Looks like they are just linter issues, shall be fixed with formatting IIUC

[mxbossard]

@aaron-prindle I fixed the bug, my new integration test is now passing, but I don't understand why the unit tests are failing.

[mxbossard]

Ok the bug is reproduced within an integration test and fixed. Do you plan to release a 1.19.1 soon ?