Prevent extra snapshot with --use-new-run #2943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There should be no snapshot for RunV2. Added a test for SingleSnapshot as well to prove that the test actually works (rather than `initialized` just not being read or set properly).
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
aaron-prindle
approved these changes
Jan 17, 2024
There was a problem hiding this comment.
Sorry for the delay and thanks for the PR here @code-asher! Just did some manually testing from the PR here and I agree this change should not change any critical functionality for kaniko w/ --use-new-run. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2800
Description
This removes an extra snapshot that can occur when using
--use-new-run.Submitter Checklist
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.