Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add retries to fs cleanup #3136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ezloj
Copy link

@ezloj ezloj commented Apr 25, 2024

Fixes 1697

Description

This attempts to mitigate some of the sources for issues described in
#1697

The potential problems that this might address is when something is
writing to the filesystem during it's deletion but is otherwise safe
to be removed anyway

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Includes unit tests
  • Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • The code flow looks good.
  • Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--retry-cleanup` to run filesystem cleanup retries for multistage builds and for builds that explicitly ask for cleanup with the `--cleanup` flag

Copy link

google-cla bot commented Apr 25, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ezloj ezloj force-pushed the feature/add_retries_to_fs_cleanup branch from ab1dd4a to f11a4fe Compare April 25, 2024 08:04
This attempts to mitigate some of the sources for issues described in
GoogleContainerTools#1697

The potential problems that this might address is when something is
writing to the filesystem during it's deletion but is otherwise safe
to be removed anyway
@ezloj ezloj force-pushed the feature/add_retries_to_fs_cleanup branch from f11a4fe to 73ca2e7 Compare April 25, 2024 08:06
StefanSchrass

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants