adding LABEL command #44
Conversation
pkg/commands/label.go
Outdated
|
|
||
| for _, kvp := range labels { | ||
| logrus.Infof("Applying label %s=%s", kvp.Key, kvp.Value) | ||
| existingLabels[kvp.Key] = kvp.Value |
There was a problem hiding this comment.
I think you might need to parse out backslashes or quotes before setting the label (I had to for the ENV command, so this might be similar)?
for example, the command
LABEL myDog=Rex\ The\ Dog \
in the Dockerfile should be saved as myDog="Rex The Dog" in the config
| existingLabels := config.Labels | ||
|
|
||
| // Let's unescape values before setting the label | ||
| shlex := shell.NewLex('\\') |
There was a problem hiding this comment.
So there are two different escape tokens, if you pass in a string version of the command (like here) then the parser will determine which one it is for you, and you can pass that into shell.NewLex()
pkg/commands/label_test.go
Outdated
| expectedLabels := map[string]string{ | ||
| "foo": "override", | ||
| "bar": "baz", | ||
| "multiword": "lots of words", |
There was a problem hiding this comment.
I think that this should parse to "lots\ of\ words", since the first backslash should indicate that the second remains. Hopefully if you make the change above, this will just parse correctly?
There was a problem hiding this comment.
whoops, sorry, it actually should stay "lots\\ of\\ words" in the config.
There was a problem hiding this comment.
yeah, if I pass in "lots\\\\ of\\\\ words" then I'll get "lots\ of\ words" back out.
priyawadhwa
added
the
area/dockerfile-command
Fixes #7