adding VOLUME command #62
Conversation
| @@ -0,0 +1,12 @@ | |||
| [ | |||
| { | |||
| "Image1": "gcr.io/sharif-test/docker-test-volume:latest", | |||
pkg/commands/commands.go
Outdated
| @@ -54,6 +54,8 @@ func GetCommand(cmd instructions.Command, buildcontext string) (DockerCommand, e | |||
| return &LabelCommand{cmd: c}, nil | |||
| case *instructions.UserCommand: | |||
| return &UserCommand{cmd: c}, nil | |||
| case *instructions.VolumeCommand: | |||
| return &VolumeCommand{cmd: c, buildcontext: buildcontext}, nil | |||
There was a problem hiding this comment.
Where is the buildcontext used?
There was a problem hiding this comment.
It's not, I'm getting rid of it.
pkg/commands/volume.go
Outdated
| // Create any directories that don't already exist | ||
| destVolume := volume | ||
| logrus.Infof("Creating directory %s", destVolume) | ||
| if err := os.MkdirAll(destVolume, 0755); err != nil { |
There was a problem hiding this comment.
So I think you actually don't have to create the volume if it doesn't exist, it looks like you just have to add it to the config and then docker mounts it during "docker run". That might explain why container-diff isn't finding certain directories in the docker built version of the test.
There was a problem hiding this comment.
Well that makes my life easy. Will fix.
|
I'm now adding volume mounted directories to our whitelist, but this causes RUN commands to fail rather than ignore them. Is that intended? |
|
Oh yah I think RUN commands should still be able to execute, we just shouldn't snapshot any changes made in volume mounted directories. If we create the directory but also add it to the whitelist this should work |
|
Yep, verified that that's how it works and added a test for it. |
…-builder into volume-cmd
…-builder into volume-cmd
…-builder into volume-cmd
…uilder into volume-cmd
No description provided.