fix: allow upstream package comparison (#61)

This change ensures the Compare Revision dropdown on the Package Revision Page lists the upstream package anytime the upstream package is known.
GoogleContainerTools · Jun 29, 2022 · 292b98d · 292b98d
1 parent c4c1976
commit 292b98d
Showing 1 changed file with 26 additions and 26 deletions.
diff --git a/plugins/cad/src/components/PackageRevisionPage/PackageRevisionPage.tsx b/plugins/cad/src/components/PackageRevisionPage/PackageRevisionPage.tsx
@@ -211,34 +211,34 @@ export const PackageRevisionPage = ({ mode }: PackageRevisionPageProps) => {
 
     let upgradeAvailable = false;
 
-    if (isLatestPublishedRevision(thisPackageRevision)) {
-      const upstream = getUpstreamPackageRevisionDetails(thisPackageRevision);
-
-      if (upstream) {
-        const upstreamPackage = findPackageRevision(
-          thisPackageRevisions,
-          upstream.packageName,
-          upstream.revision,
-        );
-
-        if (upstreamPackage) {
-          diffItems.push({
-            label: `Upstream (${getPackageRevisionTitle(upstreamPackage)})`,
-            value: upstreamPackage.metadata.name,
-          });
-        }
+    const upstream = getUpstreamPackageRevisionDetails(thisPackageRevision);
 
-        const allUpstreamRevisions = filterPackageRevisions(
-          thisPackageRevisions,
-          upstream.packageName,
-        );
-        latestPublishedUpstream.current =
-          findLatestPublishedRevision(allUpstreamRevisions);
+    if (upstream) {
+      const upstreamPackage = findPackageRevision(
+        thisPackageRevisions,
+        upstream.packageName,
+        upstream.revision,
+      );
 
-        if (
-          upstream.revision !== latestPublishedUpstream.current?.spec.revision
-        ) {
-          upgradeAvailable = true;
+      if (upstreamPackage) {
+        diffItems.push({
+          label: `Upstream (${getPackageRevisionTitle(upstreamPackage)})`,
+          value: upstreamPackage.metadata.name,
+        });
+
+        if (isLatestPublishedRevision(thisPackageRevision)) {
+          const allUpstreamRevisions = filterPackageRevisions(
+            thisPackageRevisions,
+            upstream.packageName,
+          );
+          latestPublishedUpstream.current =
+            findLatestPublishedRevision(allUpstreamRevisions);
+
+          if (
+            upstream.revision !== latestPublishedUpstream.current?.spec.revision
+          ) {
+            upgradeAvailable = true;
+          }
         }
       }
     }