fix: update resource viewer to handle null fields (#269)

This change fixes an issue where the Resource Viewer Dialog crashes when the object to be displayed contains a field set to null.
GoogleContainerTools · May 28, 2023 · a02d941 · a02d941
1 parent 088c268
commit a02d941
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/...sourceViewerDialog/components/FirstClassViewers/StructuredMetadata/StructuredMetadata.tsx b/...sourceViewerDialog/components/FirstClassViewers/StructuredMetadata/StructuredMetadata.tsx
@@ -55,7 +55,11 @@ const useStyles = makeStyles({
 
 const normalizeMetadata = (metadata: Metadata): void => {
   Object.keys(metadata).forEach(key => {
-    if (metadata[key] === undefined || metadata[key] === '') {
+    if (
+      metadata[key] === undefined ||
+      metadata[key] === null ||
+      metadata[key] === ''
+    ) {
       delete metadata[key];
     }
 

diff --git a/...ResourceViewerDialog/components/FirstClassViewers/StructuredMetadata/resources/default.ts b/...ResourceViewerDialog/components/FirstClassViewers/StructuredMetadata/resources/default.ts
@@ -62,7 +62,7 @@ const populateMetadata = (
 ): void => {
   const STANDARD_K8S_FIELDS = ['apiVersion', 'kind', 'metadata'];
 
-  const firstLevelFields = Object.keys(object).filter(
+  const firstLevelFields = Object.keys(object || {}).filter(
     key => !STANDARD_K8S_FIELDS.includes(key) || depth !== 1,
   );