Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the same version as in the sdk in set-namespace fn #787

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

mengqiy
Copy link
Contributor

@mengqiy mengqiy commented Mar 23, 2022

kubernetes/kube-openapi#285 will break
things if we are using inconsitent version of kube-openapi

kubernetes/kube-openapi#285 will break
things if we are using inconsitent version of kube-openapi
@mengqiy mengqiy changed the title Use the same version as in the sdk Use the same version as in the sdk in set-namespace fn Mar 23, 2022
Copy link
Contributor

@yuwenma yuwenma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

@mengqiy mengqiy merged commit 77bf0f4 into GoogleContainerTools:master Mar 24, 2022
@mengqiy mengqiy deleted the setnsdep branch March 24, 2022 00:19
yuwenma pushed a commit that referenced this pull request May 4, 2022
* Use the same version as in the sdk

kubernetes/kube-openapi#285 will break
things if we are using inconsitent version of kube-openapi

* use kube-openapi e816edb12b65 for apply-replacements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants