Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add wasm functionality to apply-setters and rewrite to new go kpt fn sdk #915

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wmuizelaar
Copy link
Contributor

Just like #911 - this adds wasm functionality to apply-setters. As discussed during the latest office-hours I also attempted to port the functionality to the new SDK.

Please review thoroughly and share feedback - I tried to keep as much of the old code in place as possible, but I wasn't able to properly read the 'old' ConfigMap configuration structure, so had to craft a new config format - which is obviously a breaking change. I'm not too happy with that, so ideas on how to prevent that are appreciated ;-)

@yuwenma
Copy link
Contributor

yuwenma commented Sep 16, 2022

Hi, @wmuizelaar, thank you for the contribution.

We do not want to add new features to the apply-setter functions, as explained in kptdev/kpt#3131. For your use cases, I'd recommend using apply-replacements function instead as we talked about in the office hour. I understand the apply-replacement may not be sufficient enough from the feasibility and maintenance perspective. If that's the case, do you mind sharing your examples in kptdev/kpt#3131 so we can evaluate and further help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants